-
-
Notifications
You must be signed in to change notification settings - Fork 16.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): [radio-button] model-value click style lost and format test file #16692
Conversation
👋 @warmthsea, thank you for contributing element-plus. |
Hello @warmthsea, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
🧪 Playground Preview: https://element-plus.run/?pr=16692 |
这里是不是可以根据is-active类来判断ns.is('active', modelValue === actualValue) |
我不确定那种更改方案最好 |
This is along the right lines. I'd like to throw out an idea to fine-tune it. @include b(radio-button) {
@include when(active) {
// checked style here
}
} Then we don't need to change anywhere else. What do you think? |
fix: #16689
Before
After